Mark Murphy

icon location Cambridge, UK

Results 32 comments of Mark Murphy

Header flexibility

Any thoughts @djones6 ? 😀

Header flexibility

Thanks @djones6 for your comments, I'll give this some thought and reply this week. I really appreciate the crypto support your library provides but I understand the need for scope...

Header flexibility

Hi @djones6 . The most obvious change would be to turn Header into a protocol like Claims which would also have the benefit of allowing Header.encode() to overridable like Claims.encode()....

Header flexibility

Any thoughts on this @djones6 ?

Header flexibility

I have made a pull request based on the HeaderProtocol option: https://github.com/IBM-Swift/Swift-JWT/pull/84 I welcome any thoughts.

Support for JsonSerializer.Context when StreamingContext is removed

I also get warnings in .NET 8 for code like: ```csharp jsonSerializerSettings.Context = new StreamingContext( StreamingContextStates.All, optionsDict); ``` Warnings are: ```text Warning SYSLIB0050 : 'StreamingContextStates' is obsolete: 'Formatter-based serialization is...

`string` should be `string?` for optional properties if `"generateOptionalPropertiesAsNullable": true`

Yeah, I noticed this for strings and DateTimeOffset values. Any chance of a fix @RicoSuter?

`string` should be `string?` for optional properties if `"generateOptionalPropertiesAsNullable": true`

>By expecting my source to define nullable (and therefore optional) properties explicitly, why would I ever use generateOptionalPropertiesAsNullable? Hi @omarmciver , I'm not sure I completely understand your post (and...

Generating C# Models compatible with both Newtonsoft.Json and System.Text.Json

Great idea @GREsau. What did you do in the end as I also want to migrate incrementally?

fix tiny error in docs nav

Thanks @jmartin-acquired for this. We are in principle very happy to accept PRs but I believe I have been contacted by your company and am hoping we will have a...