Mark R.

Results 9 comments of Mark R.
trafficstars

This looks like a bug in expvar itself, as it doesn't use a JSON encoder but rather just spits out key-value strings with the `%q` format specifier... see https://github.com/golang/go/blob/master/src/expvar/expvar.go#L331

This is an issue with PHP's wrapping of the actual C function, I think that the space check would be added along with !== false.

Wouldn't hurt to see whether checking for false and empty string does the job. Otherwise, we could use stream_get_meta_data and check for 'unread_bytes', etc.

I think that this issue can be closed since #10 was merged.

I have a tentative PR that works with the provided test case, by stripping the mount points from the paths before adding them to the monitoring list: https://github.com/fsnotify/fsevents/pull/58

absolutely agree that there's probably a need to revisit the public API. I'm not familiar enough with the project to offer significant input right now but am happy to. help...

This is still a tentative POC, as we should probably coalesce all paths per-device and only call `EventStreamCreateRelativeToDevice` or `EventStream` once. Also, I haven't tried mixing multiple paths, each from...

Do you have any suggestions on how you'd add buffering messages that need to be sent post-reconnection?

I think the optimal solution would be to buffer (in _writeFrame()) and if we pass a threshold of failed reconnects, then throw an exception. Otherwise, just dump it all once...