Mark Miller

Yeah, no problem. @chsalgado is who I've been working with, and this is a feature to help the .NET team get a handle on target framework usage for packages across...

Any special instructions for running the tests? I cannot repro these failures locally.

> @marklio If you are using Visual Studio the C# tests (what's failing) should be automatically populated in the test explorer. Otherwise you can use `dotnet test .\ComponentDetection.sln` Yeah, I...

I know csc doesn't do it by default, but the targets should be setting it if you are targeting a supported framework: https://github.com/microsoft/msbuild/blob/a78f69dae3d599544e52b69b15e5bd71e27cd3b3/src/Tasks/Microsoft.NETFramework.CurrentVersion.props#L108

I'm looking into why this behavior isn't working.

Looks like this tried to get fixed with https://github.com/microsoft/msbuild/issues/2912, but the fix wasn't correct. It is now being tracked by https://github.com/microsoft/msbuild/issues/4566

I'll take a look

It looks like you were right. Writing nibbles is busted. When we generate the record writer node tree, we try to write a regular byte array instead of packing it...

More testing has revealed it is still not right. Stay tuned...

You'll also need the BinaryWriter fix in 59e0556db70259e72b3ca464e24a0b7df14f5f0e