Marcos Gómez Vilches

Results 25 comments of Marcos Gómez Vilches

@pmikolajek it must be fixed in beta3 release

@lcavero could you please test against dev-master , I fix xml mapping

@pandresp could you please update to dev-master to test if this fix is working?

Yes, but look at this: https://github.com/markitosgv/JWTRefreshTokenBundle/blob/40f03d12d8167f5fd1124ef9befb8ac3b07e1f87/Resources/config/mongodb/doctrine-document/RefreshToken.mongodb.xml#L8 Are you checking against last dev-master?

Ok @lcavero Could you please test changing line 9 of https://github.com/markitosgv/JWTRefreshTokenBundle/blob/40f03d12d8167f5fd1124ef9befb8ac3b07e1f87/Resources/config/mongodb/doctrine-document/RefreshToken.mongodb.xml#L9 to this: ``` ```

You're right @pandresp , mistake was introduced in PR #167 . Solved in b05c321ccc24205966f90222307f1cc783d14dfa, f5472176b7599f0ea39c1b868d542cda722c33b3 and waiting for a new release when @lcavero confirms

Hi @konshensx16 thanks for your comments. 1) It's ok to save it in localStorage, or as a cookie 2) You could read refresh_token from cookie, look at this: https://github.com/gesdinet/JWTRefreshTokenBundle/issues/132#issuecomment-461333191

@konshensx16 as @norkunas said, there's no problem because user can revoke refresh token. Think about PHP session cookies, it's the same, someone could stole it and grant access. Worst case...

I was trying in a new branch php 5.6 test, but everything seems to be OK. https://travis-ci.org/gesdinet/JWTRefreshTokenBundle/jobs/433129651 Are you sure is this line? I mean this error looks like new...