Mark Erikson

Results 1264 comments of Mark Erikson

Yeah, the listener middleware's implementation is explicitly "run checks _after_ each action is dispatched", and `condition()` is implemented internally as yet another listener instance. So, it _won't_ check right away...

We _have_ had a couple cases where it would be nice to trigger a listener right away. One conceptual issue: `addListener.predicate` accepts an action, as does `condition`. If we trigger...

This is now available in https://github.com/reduxjs/redux-toolkit/releases/tag/v1.9.0-alpha.1 . Please try it out and let us know how it works!

Hmm. That... actually sorta makes sense, given how we implemented `upsertQueryData`. We opted to implement it as a tweak to our existing "actually start this async request" logic. That runs...

That seems reasonable to me, yeah

Yeah, the big issue here is that for very valid historical reasons, we have three separate libraries, each with their own repos: - https://github.com/reduxjs/redux / `redux`: the original Redux core...

Hmm. I'm actually not quite sure what the "RTK link" suggestion is, or what you mean by "the rabbit hole of parsing the core docs". Can you clarify that? The...

Thanks for the great feedback! I'm generally curious how this might overlap with the much more complex "Redux modules" concepts from libraries like the ones I linked at https://github.com/reduxjs/redux-toolkit/issues/1326#issuecomment-1279438077 ....

Hmm. I'm looking at this, and yeah, not sure how easy it would be. Looks like `retry()` is used to wrap the base query, but that's a very separate thing...

One issue here is that this really only works if the user is passing in the individual slice reducers to `configureStore`. If they are creating the root reducer themselves, such...