Mark Edwards
Mark Edwards
@allancaffee, I've already done work to implement typing on top of aiodataloader. How about I get a PR done in the next week or two, and you can take a...
Seconded, we have this issue as well. It makes it very easy for the user to lose pasted information.
Please either fix this or inform the MUI project that this will not be fixed so that project can take appropriate action.
@pcraciunoiu I think the location of this definition is in Graphene, but what you are claiming does not appear to be the case, at least not any more: https://github.com/graphql-python/graphene/blob/master/graphene/relay/connection.py#L96
Not as far as I can tell: https://github.com/graphql-python/graphene/blob/master/graphene/relay/connection.py#L79 If you follow the class, `Field.required` defaults to False, and it's not specified there. But I'm not very expert on the Graphene...
PR created. I've tested pretty thoroughly in my app and it works well. Let me know if there are any concerns or questions.
I realised there is the same issue in `get_objects_for_group`, so I made the same change there. Also, added tests to confirm that calls to `get_objects_for_user` and `get_objects_for_group` do not raise...
This repo is actually actively monitored and maintained, although it's a bit slow. I'm planning to take a look at the PR, but made an initial comment about formatting. I'll...
Following up here, @aawilson has a PR that is nearing completion, and will result in a fully-typed release of aiodataloader (I expect this to be 0.3.0). @erikwrede, ideally graphene should...
Closing this, now that #25 is merged. I plan to do a typed release of aiodataloader in the coming days.