Mark Edmondson
Mark Edmondson
> This is expected, because file is of type ActiveStorage::Blob, but moderated_comment.image is of type ActiveStorage::Attached::One Thanks - removed that test from the code. > Are you casting non-saved records...
FYI `Subscription#optional_targets` is failing too because it serializes `ActiveSupport::TimeZone`
PR that allows option passing to mute the exception here: https://github.com/premailer/css_parser/pull/132
~Spent~ Wasted a lot of time on this today before finding this, we effectively got to the same point as @avit's cleanup but the requirement of `date.format.default` when Rails wasn't...
@sl0thentr0py I think you're right. I added a `*** CLOSING THREAD ***` puts: ``` 13:01:35 - INFO - Guard is now watching at '****' 13:02:02 - INFO - Running: test/graphql/resolvers/test.rb...
Yeah, with guard. I'll see what I can do. I would imagine Spring may suffer a similar problem and if not, it could provide a solution.
If https://github.com/premailer/premailer/pull/418 gets merged then it'll be automatically supported through https://github.com/fphilipe/premailer-rails/blob/main/lib/premailer/rails/customized_premailer.rb#L11 using `Premailer::Rails.config.merge!(rule_set_exceptions: false)`
@ilyaskarim This still exists in 4.0.14, the line in question is: ``` if(g.opts.enter!==V.ENTER_BR&&n&&n.previousSibling&&n.previousSibling.previousSibling&&"BR"===n.previousSibling.previousSibling.tagName&&n.previousSibling.previousSibling.remove() ``` This was introduced in 4.0.9, seemingly to fix "Removing a sentence after a BR tag, does...
It seems like adding the submitter might be critical to Safari 15 in iOS. See https://discuss.hotwired.dev/t/checkbox-form-does-not-submit-on-safari-and-mobile-chrome-using-requestsubmit/4011/3 I could only get it to work with a submitter parameter.
Hey @nertzy if you're happy to add me as an owner on [Rubygems](https://rubygems.org/profiles/markedmondson) I can get this out.