Mark Doliner
Mark Doliner
BACKGROUND Two kinds of exceptions can be thrown by a handler processing a Thrift request: - Those that are defined as `exceptions` in a .thrift file. The server serializes them...
This changes the client code generated for `--target thrift-server` so that it returns instances of the generated thrift classes instead of plain objects. I believe the client code generated for...
This changes exception classes generated for `--target thrift-server` so that they extend `ErrorThriftLike` instead of `ThriftLike`. There's a [corresponding `thrift-server` change](https://github.com/creditkarma/thrift-server/pull/132) to add the `ErrorThriftLike` class. As mentioned in [the...
BACKGROUND Two kinds of exceptions can be thrown by a handler processing a Thrift request: - Those that are defined as `exceptions` in a .thrift file. The server serializes them...
When making a thrift request with HttpConnection, if the server returns a non-2xx response code currently [the full response object is included in the promise rejection](https://github.com/creditkarma/thrift-server/blob/68adfa6c020695e99de610d1958bba27d00ebf60/packages/thrift-client/src/main/connections/HttpConnection.ts#L252). According to [the DefinitelyTyped...
## Description Exception classes should extend this so that they derive from Error. ## Motivation and Context As mentioned in [the thrift-typescript GitHub issue](https://github.com/creditkarma/thrift-typescript/issues/178), it's useful for exceptions to derive...