Mark Lee

Results 10 comments of Mark Lee

> > FYI, you might need to run golden config updates: https://github.com/apple/axlearn/blob/main/docs/01-start.md#testing > > Thanks! > > Ran golden config, tests should pass now with available test data. Thanks, did...

Hi @vishesh9131, you can view your CI logs in circleci, e.g.: https://app.circleci.com/pipelines/github/apple/axlearn/2776/workflows/84ee8526-8e05-4de1-ae48-8354f607af36/jobs/5975

> I see the CI fails for test `TestEvaluateFromFile.test_evaluate_from_eval_set` with error `#22 453.1 axlearn/open_api/common.py:440: KeyError` > > This is unrelated to the changes in this PR, I already rebased the...

Does it work if you install from source instead? `pip install -e .[core,apple-silicon]`. The pypi wheel may be slightly behind.

Hi @samos123 , you can use the input dispatcher: https://github.com/apple/axlearn/blob/ac63eef8a76ee8e7fcb7e539ca1331e885ce286c/axlearn/common/input_tf_data.py#L1165-L1167 https://github.com/apple/axlearn/blob/ac63eef8a76ee8e7fcb7e539ca1331e885ce286c/axlearn/common/input_dispatch.py#L17-L33 Some hosts will produce padding feeds which will be dropped during input dispatch. I have some ideas to make...

> @markblee could you please review once more? I moved the get_xla_options and get_megascale_options to pathways_util.py. Nothing else changed. I also re-ran my manual test. Thanks, I still see them...

I wonder how the CI passed with those typos. Do they fail locally for you?

> @markblee The flag escaping has indeed been painful! I am not familiar with the process of loading from flagfiles, could you elaborate on how it would be implemented? `absl`...

I'll need to run some internal tests before I can merge it -- hopefully soon!