Mark Bates

Results 105 comments of Mark Bates

You don’t need anything special to open a PR. fork it, fix it, and then open the PR.

That sounds great! I would love to see the plush binary get that.

The new v2 API allows for implementing of a Store interface, so please PR up an implementation! :)

This would have to be implemented as an optional store, not the normal default store. And yeah, sounds like warnings are definitely required for this proposal. Perhaps even a confirmation...

That choice is yours, no one is forcing you to move. It's "potentially" a replacement in that you can potentially replace Packr with it. I have stated that I believe...

Go for it. I don’t use this much anymore since most planes have WiFi :)

Checking for `nil` is really big start. Prevent crashes is always a big win. Here's another example from the `v2` API where an `error` would be very useful. ```go func...