failing to build when a folder includes ".go" in path

Open rickyshrestha opened this issue 6 years ago • 5 comments

Some of the repos that we import has ".go" in the file path. eg. https://github.com/nats-io/nats.go.

When using packr v2 to build packr parses the folder path as a file and reports error ".../nats.go" is a directory.

The issue is in findAllGoFiles in jam/parser/finder.go

I am happy to raise a PR if you like

May 15 '19 13:05 rickyshrestha

PRs are welcome.

May 21 '19 12:05 markbates

@rickyshrestha are you taking this one? If not I would like to. I wanted to give it a try so I already have it fixed locally.

Jun 04 '19 10:06 dpromanko

Hi, I have the same issue. Is there any status about this?

Thanks.

Jun 13 '19 15:06 mytototo

@markbates could you please allow me access to raise the PR.

@dpromanko I can raise it as soon as i have access. I got it fixed locally and been using that version.

Jun 28 '19 10:06 rickyshrestha

You don’t need anything special to open a PR. fork it, fix it, and then open the PR.

Jun 28 '19 11:06 markbates