markarmanus

Results 5 comments of markarmanus

Cant recreate the issue in any env. and the stack overflow post seems inaccessible to me as i dont have a @expensify email Attemtped local on Iphone 13 from both...

Proposal @sketchydroide I can recreate the issue scuccefully. The issue is really simple, When this.state.imageError is true in Avatar.js ```JSX {_.isFunction(this.props.source) || this.state.imageError ? ( ) : ( this.setState({imageError: true})}...

@sketchydroide Yes sir :D that sounds perfect with me ! I sent an email to join the slack channels but never got a response back

@parasharrajat @0xmiroslav Your solution would 100% work. but if we follow SOLID princibles. The Avatar component is responsible for honouring its interface. In this case the interface says imageStyles is...

@0xmiroslav I think you might have not understood my comment. Lets say you are a user of the component Avatar When looking at the props you would see imageStyles. This...