mark-terry

Results 8 comments of mark-terry

Option 1: https://github.com/testcontainers/testcontainers-java/pull/1781 Container reuse in testcontainers is still WIP and appears to have outstanding work around assigning networks. This does not appear to be viable at this point in...

> I think we need to first define which is our goal, because I see 2 possibility here: > > 1. Follow the specs, then we need to reject everything...

> Have you tested this PR with a Consensus client? since `eth_getLogs` is critial after the merge It's currently running with Teku on Sepolia without any obvious issues. 👍

@xd1gital The CL is using a different set of APIs ([Engine API](https://besu.hyperledger.org/en/stable/public-networks/reference/engine-api/)) to interact with Besu, which return a different set of statuses. They're detailed here: https://github.com/ethereum/execution-apis/blob/main/src/engine/specification.md The response from...

@Jakeler We're currently reviewing a few approaches to resolve this issue. Are you able to share your usecase that experiences this issue? Are you tracing every block?

Besu does not calculate totalDifficulty for ommer blocks - the difficulty is explicitly set to 0. See: [UncleBlockResult.java:36](https://github.com/hyperledger/besu/blob/18b8a63e3e8953fce90046263b3bf393153275be/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/UncleBlockResult.java#L36) Given ommers shouldn't be a concern post-merge, it's probably not worth updating....

PR here: https://github.com/ethereum/hive/pull/661