Mark Hammond comments

Results 5 comments of


                                            Mark Hammond

Set a prior that maps are physical/non-negative?

Should the solutions described above still work when the map coefficients and amplitude are marginalised, like in https://starry.readthedocs.io/en/latest/notebooks/EclipsingBinary_FullSolution/ ? I have applied a positive pixel constraint to the example in...

Adding the option to impose positive values on fitted eclipse maps

I've fixed the conflict in S5_lightcurve_fitting/differentiable_models/StarryModel.py where the main branch was updated to allow negative rp; the positive maps branch now allows that to happen when pixel sampling isn't used

Adding the option to impose positive values on fitted eclipse maps

Yes, go for it!

Adding the option to impose positive values on fitted eclipse maps

I found that the pixel trace saving in gradient_fitters.py wasn't working as it needed converting to arviz format before saving (did it work for you previously? It could be different...

Adding the option to impose positive values on fitted eclipse maps

I've also added the option to output the various parts of the calculated lightcurve from plot_s5.py with a "record_plot_data" switch, which I've needed for plotting things like residual eclipse mapping...