Marja Hölttä

Missing coverage: Resizable / Growable (Shared)ArrayBuffers: Atomics.*

1

There seem to be no tests which pass resizable / growable (Shared)ArrayBuffers to various Atomics functions, like Atomics.wait, Atomics.waitAsync, Atomics.notify Atomics.load, Atomics.store, Atomics.exchange, Atomics.compareExchange Atomics.add, Atomics.sub Atomics.and, Atomics.or, Atomics.xor And...

E.g., ``` let ab = new ArrayBuffer(100, {maxByteLength: 200}); let ta = new Uint8Array(ab, 0, 10); Object.freeze(ta); // Should throw! ``` V8 currently has a bug in here but test262...

There was a bug in V8 where I hadn't modified Object.defineProperty / Object.defineProperties to deal with RAB / GSAB. The repro is very simple: ``` const gsab = new SharedArrayBuffer(1024,...

I noticed none of the tests in built-ins/TypedArray/prototype/subarray/ pass the resizable-arraybuffer flag, so looks like there's no test coverage. cc @syg @sarahghp

There are some tests which pass RAB/GSAB to TypedArray.prototype.set, but those don't seem to cover enough cases. Proof: I now have v8 in a state where all TA.p.set -related test262...

built-ins/TypedArray/prototype/map/callbackfn-resize.js seems wrong

3

In this part: ``` result = sample.map(function(element, index, array) { if (elements.length === 0) { try { buffer.resize(2 * BPE); finalElement = undefined; finalResult = NaNvalue; ... } catch (_)...

We don't seem to have test for the more complicated cases, e.g: create resizable array buffer size 4, max 8 create length-tracking TypedArray (assuming 1-byte elements for this pseudo code)...

Missing coverage: Resizable / GrowableSharedArrayBuffers: parameter conversion resizes the underlying buffer

1

In most TypedArray.prototype funcs, it's possible that the underlying ArrayBuffer gets resized when we're converting the parameters. E.g., for TypedArray.prototype.fill: 1. Let O be the this value. 2. Perform ?...

There are tests like built-ins/Array/prototype/every/callbackfn-resize-arraybuffer , which invoke an Array.prototype.function with a TypedArray with resizable backing. But looks like we don't have tests for all funcs in Array.prototype. E.g., Array.prototype.join...

Like the various "callbackfn-resize-arraybuffer" tests, e.g., built-ins/Array/prototype/every/callbackfn-resize-arraybuffer, but the resizing happens in Number.prototype.toLocaleString or BigInt.prototype.toLocaleString (which will be invoked repeatedly by toLocaleString when converting the elements to strings. cc @jugglinmike...