Mario Lenz

Results 456 comments of Mario Lenz

@dawidd6 Sorry, I didn't have the time to have a closer look at this. I hope I'll be able to, soon. Meanwhile, could you please add a [changelog fragment](https://docs.ansible.com/ansible/latest/community/development_process.html#making-your-pr-merge-worthy)?

> A very quick look says this is good! I forget how we get this approved... is it a forum post? with SC poll/vote? @samccann You've started [Ansible 10 roadmap](https://forum.ansible.com/t/1751)...

Is this still up to date and needed? If yes, we might also change [supports_check_mode to false](https://github.com/ansible-community/ansible.content_builder/blob/80ad207031f14cb2af65b15acb5830670028db2c/roles/module_openapi_cloud/templates/module_directory/vmware_rest/header.j2#L91) while we're at it (see [here](https://github.com/ansible-collections/vmware.vmware_rest/pull/618#issuecomment-3234228938)) and start to nag people about merging...

> It probably works. It's just not tested. Cool! Then I'll give it a try. BTW Good idea to add a checklist!

> We do not have access to a VMware vSphere cluster ourselves and would be very happy to receive support here. Perhaps it would be best if you joined us...

I'm sorry, but my priority ATM is to make the collection work with the [upcoming ansible-core 2.19 release](https://forum.ansible.com/t/40759) (#2388 and #2391). It turns out that this is harder than I...

I'm sorry, I didn't find much time to work on this collection during the last weeks. I hope I'm able to review this PR soon.

Could you please add a [changelog fragment](https://docs.ansible.com/ansible/latest/community/development_process.html#creating-changelog-fragments)? It would be great to have a test case for this. Maybe we can re-use a disk that's created here: https://github.com/ansible-collections/community.vmware/blob/ac3ad91e6fd9bea6e7dab5f7bb682a959b9e7b80/tests/integration/targets/vmware_guest_disk/tasks/main.yml#L68 Something like...