mario ma

Results 45 comments of mario ma

> for instance: https://github.com/backstage/backstage/pull/20932/files#diff-fd24c3513000f2c84e0f9310bcb6efa282b69c472b38fd73b1088d15330bf66dR117 > > The `customProvider` is underlie `src.layout.SignInPage` so `tokenInvalid` key should defined like ? > > ``` > layout: { > signInPage: { > tokenInvalid: 'Token...

> @mario-mui sorry just getting back up to speed after the holidays. > > I wouldn't pay too much attention to the filepath and filenames as those can change frequently...

@benjdlambert @Rugvip Sorry to disturb you, since there is no new comment or other thing happen to this PR for two weeks. I want to know, is this PR being...

> @mario-mui sorry we've been pretty slammed with a lot of work that last few weeks, so sorry it's taking a while. This is on our TODO to sit down...

> This is looking great, just a few little things that we want to iron out here too. Cool, I will fix this today

run in docker with better-sqlite3, I got this error. yarn dev with better-sqlite3 works fine and run in docker with pg also works fine

> @mario-mui sorry - been a busy few weeks so not had chance to get round to this yet! sure, can someone else review this pr ?

> I see there are conflicts now. > > We'll get to it as soon as possible. ok,It's done @freben

Are there something new? Do we have jaeger backstage plugin?

> LGFM @aljesusg Someone can merge this PR?