mario ma

Results 45 comments of mario ma

ping @benjdlambert

@benjdlambert Shall we start review this PR, 😄

new PR for catalog translations https://github.com/backstage/backstage/pull/23392

@angeliski Do we had another RFC link. I want to know the newest solutions about i18n

@vinzscam @tikabom @Rugvip please review this PR, I had fix all unit test

@tikabom PR not merge automatically, is this need any other reviewer to approve ?

@benjdlambert @Rugvip I had change messages keys to nested and camelCase. Please review again

@benjdlambert This is ready for merge?

``` message: { componentName: { key1: key2 } } ``` what about this translation structure? @benjdlambert

for instance: https://github.com/backstage/backstage/pull/20932/files#diff-fd24c3513000f2c84e0f9310bcb6efa282b69c472b38fd73b1088d15330bf66dR117 The `customProvider` is underlie `src.layout.SignInPage` so `tokenInvalid` key should defined like ? ``` layout: { signInPage: { tokenInvalid: 'Token is not a valid OpenID Connect JWT Token'...