maria-farooq

Hi @anhntnguyen thanks for creating PR. Great work on adding unit tests. Can you please run testsuit in ci against your branch so we have guarantee things have no regression....

Hi @muhammadbilal19 Thanks a lot for your PR Sorry about the delay, we have been under some fires lately. Here are a couple of comments that i have after a...

Thanks @muhammadbilal19 Please check, your queries for mysql and hsql are logically different. here is your mysql query ``` SELECT * FROM restcomm_incoming_phone_numbers WHERE phone_number=#{phone_number} or phone_number = "+" +...

@muhammadbilal19 the queries you changed are corresponding to method `MybatisIncomingPhoneNumbersDao .getIncomingPhoneNumber`. Did you check the references of this method in project to see where-ever it is used, does that part...

Hi @muhammadbilal19 do we have an update here Regards Maria

running ci tests on this branch [here](https://mobicents.ci.cloudbees.com/job/RestComm-For-Specific-Branch/86)

@muhammadbilal19 following tests are failing on ci for this branch. ``` org.restcomm.connect.testsuite.http.LiveCallModificationAnswerDelayTest.holdCall org.restcomm.connect.testsuite.http.LiveCallModificationTest.holdCall org.restcomm.connect.testsuite.http.LiveCallModificationTest.testTerminateDialForkCallWhileRinging_LCM_to_dial_branches org.restcomm.connect.testsuite.http.LiveCallModificationTest.testTerminateDialForkCallWhileRinging_LCM_to_initial_call org.restcomm.connect.testsuite.http.LiveCallModificationTest.testTerminateDialForkCallWhileRinging_LCM_to_move_initial_call_to_hangup_rcml org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialClientAlice_InvalidRCML org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialNumberPstn_404NotHere org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialNumberPstn_500ServerInternalError org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialNumberPstn_BusyHere org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialNumberPstnBobDisconnects org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialNumberPstnForbidden org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialNumberPstnNoAnswer org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testSubAccountClientDialsParentAccountNumber org.restcomm.connect.testsuite.telephony.ClientsDialAnswerDelayTest.testClientDialOutPstnSimulateWebRTCClientNoAnswer org.restcomm.connect.testsuite.telephony.DialActionTest.testDialActionInvalidCall org.restcomm.connect.testsuite.telephony.DialStatusCallbackTest.testDialForkNoAnswerButHenriqueStatusCallbackOnAllPostWithTimeout org.restcomm.connect.testsuite.telephony.DialStatusCallbackTest.testDialForkNoAnswerExecuteRCML_ReturnedFromActionURLWithStatusCallbacks_BobDisconnects org.restcomm.connect.testsuite.telephony.TestDialVerbPartOne.testDialUriAliceHangup ```...

Hi @muhammadbilal19 I Hope everything is fine. Do we have any update here Maria

Hi @abdulazizali77 thanks for the PR, Here are couple of comments - [x] it seems that branch has conflict with master, can you please resolve it? - [x] i can...

Dear Imran, Thanks a lot for your PR. Your contribution means a lot to us. Can you please resolve conflicts on the branch before we move onto assigning it to...