margud

Results 6 comments of margud

I was able to reproduce this issue on 8.0.x and develop branch. Found that this issue is caused because of ps.form_widget_with_error in form.html.twig file line: 97. When we cancel password...

> 1. when testing i can only see errors next to the input and no popup at the top. I rebased it with new 8.0.x branch, you can try to...

> Thanks @margud > > almost there, but I tested the PR there seems to be a bug related to the form selector that changed (that's because the creation form...

> > Thanks @margud > > I noted a few improvements as suggestion, however there are a few things that are mandatory for this PR to be merged: > >...

> Thanks @margud > > Almost good, just a few things left to fix and it's approved fixed.

> hello @margud, > > Thank you for this PR. Automaticated tests are good. > > Tested on 8.0.x branch with PHP 7.3. > > Modal is well displayed on...