Ben Mares comments

Results 675 comments of


                                            Ben Mares

Installing sunode on Apple Silicon via Conda?

Thanks @jucor for taking the initiative on this!

Define ODE with external input

Hi @yanb514! Could you please be more specific about the external force term you're trying to add? In particular, what's preventing you from simply including the force term in the...

Variables missing from 'scan_grib', but findable with xarray and cfgrib

I am also struggling with ECMWF data from the new CDS beta API due to a missing `time` dimension. In hopes of getting any "grib expert" a head-start on this,...

Cleanup Barcode.build()

There's so much to do here. I'm grinding away, fixing stuff that catches my eye. If you let me know what you like and don't like, I can eventually try...

Cleanup Barcode.build()

> Sorry for the slow reply, these were a lot of changes and needed serious attention. Ya, honestly I felt bad for dumping this mess on you. Thanks so much...

I got pytest running. Now I'm looking into: ```python > raise RuntimeError( f"Character {char} could not be converted in charset {self._charset}." ) E RuntimeError: Character 9 could not be converted...

Cleanup Barcode.build()

Ok, cool, I introduced this exception in 5ff0cd7 :joy:

Cleanup Barcode.build()

@WhyNotHugo, could you please re-review? I think I've addressed your concerns. Also, I tried to make the individual commits very simple. ~One potentially confusing commit is "Parametrize test_generating_barcodes". I preserved...

Cleanup Barcode.build()

If it's too much then let me know and I'll split it into multiple PRs.

Cleanup Barcode.build()

Thanks @WhyNotHugo!!! I agree with the rebase. I split off the non-minimal changes into #234, so the only unreviewed commits are the last four, directly addressing your feedback above, and...