Ben Mares comments

Results 675 comments of


                                            Ben Mares

Too permissive with substitution using `$ENV_VAR` instead of `${ENV_VAR}`

> and indeed it opens an input prompt for a user, even though it is specified as __token__ in the url Hmm, I wonder if the token or password contain...

Too permissive with substitution using `$ENV_VAR` instead of `${ENV_VAR}`

@psarka, could you try replacing `$GITLAB_PKG_REGISTRY_TOKEN` with `${GITLAB_PKG_REGISTRY_TOKEN}` and see if that works?

Too permissive with substitution using `$ENV_VAR` instead of `${ENV_VAR}`

Assuming my hypothesis is correct, I think it's a bug that conda-lock silently enables environment variable substitution without braces

Non-optional dependency shows up as optional

It seems like you're hitting #278, sorry about that. Would it be feasible to move `dagster_postgres` to `tool.conda-lock.dependencies`?

Side-effects from `.condarc`: packages added from `create_default_packages`

Thanks a lot for this bug report. This is very interesting. I'd actually argue that `conda-lock` picking up the `create_default_packages` is a bug. The reason is that `conda-lock` is supposed...

Non-optional dependency shows up as optional

Thanks a lot for the report. I wouldn't have expected you to find #278. I'm inclined to leave this open for visibility.

Side-effects from `.condarc`: packages added from `create_default_packages`

Is there anything about your use case that makes explicitly including everything in the `env.yaml` cumbersome?

Side-effects from `.condarc`: packages added from `create_default_packages`

Ah, got it. You know, I wouldn't be opposed to adding `.condarc` as a spec source in the sense of `--file=~/.condarc`.

Side-effects from `.condarc`: packages added from `create_default_packages`

I don't have the bandwidth to work on this. Would you like to write a `src_parser` for `.condarc` and open a PR?

Side-effects from `.condarc`: packages added from `create_default_packages`

Great! And if you see things that seem unnecessarily complicated or lacking in documentation, then if you're feeling up to it please be bold about making changes to clean things...