grayskull icon indicating copy to clipboard operation
grayskull copied to clipboard

Maintaining dependency order

Open jakirkham opened this issue 4 years ago • 1 comments

Is your feature request related to a problem? Please describe.

When looking at diffs of dependencies, sometimes they are hard to reason about due to reordering of the dependencies. Additionally some dependencies (like python tend to get listed first to make it easier to see they are there (and not forgotten) with any relevant version constraints.

Describe the solution you'd like

It would help if grayskull was able to maintain the dependency order as much as possible. This would keep diffs more compact and making it easier to catch any errors (like C/C++ dependencies that got dropped).

Describe alternatives you've considered

One alternative instead of following the recipe order would be to follow the setup.py order. As maintainers are often comparing the two, this actually makes that comparison easier. Though if the recipe is doing something different, this might be off for the first PR still

Feel free to suggest alternatives.

Additional context

Have made and looked at a few PRs with Grayskull recently and this behavior has resulted in some confusion.

jakirkham avatar Nov 10 '21 19:11 jakirkham

See https://github.com/conda-incubator/grayskull/pull/372. I still sort the dependencies, if it gets merged, it would be trivial to remove the sorted() call.

maresb avatar Aug 13 '22 13:08 maresb