Marek Scholle

Results 8 comments of Marek Scholle

I think we may hack into netty `HttpPostMultipartRequestDecoder` which accepts a `HttpDataFactory factory`. This has methods `Attribute createAttribute(...)` and `FileUpload createFileUpload(...)`. As the names suggest, `createAttribute` is a netty customization...

@hyperxpro For me, this was the first time I looked into netty internals (while following Vert.x `setExpectMultipart` implementation). So if there was somebody more competent in netty and its development,...

@hyperxpro do you have ETA on this? I know this is a bold question... When you have something, please add me to the loop (for review)

Understood. I prepared a repo https://github.com/marekscholle/vertx-form-upload with a JUnit test demonstrating the difference between * handling form fields (no `filename` in part "header"), which Vert.x (from 3.9.6) accumulates to in-memory...

Let me repeat that the goal here is to provide an option to deal with large form fields (form fields without `filename` specified, not file uploads) somehow. Today's Vert.x default...

I looked into impl and I think there should be ``` var subscription = client.subscribe(_extends({}, options, { query: query })).subscribe(function (nextResult) { var newResult = { data: nextResult.data, error: undefined,...

I found out it that `((Http1xServerConnection) request.connection()).channelHandlerContext().close();` seems to do what `request.connection().close()` used to do in Vert.x 3

Hi, may I ask on progress / ETA for this issue? It would be great if we could have `includeBuild()` working with VSCode and the "new build server" so that...