Marcus Read
Marcus Read
### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of...
Hi Doug, just a small PR to fix a couple of deprecation warnings that have cropped up with pandas 2.2. The changes are all backwards compatible with earlier pandas versions.
Since 2.3.0 there have been a few of issues raised that have this change at their root, including [here](https://github.com/dpguthrie/yahooquery/issues/169#issuecomment-1481837966) in #169, #175 and I feel like I've discussed it many...
Same issue as https://github.com/gerrymanoim/exchange_calendars/issues/207. The [release workflow](https://github.com/maread99/market_prices/blob/master/.github/workflows/release.yml) deploys to PyPI ok, although fails on the subsequent install and import check. As noted [here](https://github.com/gerrymanoim/exchange_calendars/issues/207#issuecomment-1315166772), looks like an error in the workflow's...
#### type annotations - [ ] **Use of `Optional` and `Union`** can now be migrated to using the `|` operator in the following circumstances: - [ ] **parameter annotations of...
Given the number and nature of dev dependencies, dependabot would raise PRs pretty much every day (if it weren't limited to 5). Merging them all would clog up the commit...
`parsing.parsing_start_end` handles parsing to dates/times of an `xcals.ExchangeCalendar` and the gregorian calendar. Review if this would be better handled be independent functions, perhaps with common code refactored out.
`daterange.GetterIntraday.daterange` is relatively slow and is called multiple times with each call to `prices.base.PricesBase.get` (indeed, an instance of `daterange.GetterIntraday` is created multiple times). Review method to see if it can...
`daterange.GetterDaily` accommodates getting dateranges for both daily and monthly prices, although the former is assessed against an `xcals.ExchangeCalendar` and the latter against the gregorian calendar. Review whether would be cleaner...
It would be preferable for documentation to be built with Sphinx or MkDocs and published to a dedicated docs site. Current documentation consists of: - README.md. - .ipynb notebook tutorials...