yahooquery icon indicating copy to clipboard operation
yahooquery copied to clipboard

Fix pandas 2.2 deprecation warnings

Open maread99 opened this issue 1 year ago • 5 comments

Hi Doug, just a small PR to fix a couple of deprecation warnings that have cropped up with pandas 2.2.

The changes are all backwards compatible with earlier pandas versions.

maread99 avatar Feb 01 '24 21:02 maread99

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (399284b) 93.81% compared to head (ed16dec) 92.89%. Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   93.81%   92.89%   -0.93%     
==========================================
  Files          15       15              
  Lines        1359     1380      +21     
==========================================
+ Hits         1275     1282       +7     
- Misses         84       98      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 01 '24 21:02 codecov[bot]

I'm not familiar with the deployment cadence/process, but I've also been dealing with these warnings for months and it seems this isn't making it into the release pipeline. Is that because the code coverage decreased? I also see #273 which would address this but failed to build. Or is it a general hiatus on the project?

cmjordan42 avatar Apr 05 '24 14:04 cmjordan42

@cmjordan42 It's not ideal, but in the meantime, you can use my fork: https://github.com/ScottSauers/yahooquery.

It fixed the warnings for me.

ScottSauers avatar Apr 13 '24 22:04 ScottSauers