Marcus Read
Marcus Read
One thing that doesn't seem to sit right with this library is that it's on a fork. I was wondering whether any move to Rust and support for polars would...
This is great! Thank you very much! Indeed, thank you for all the recent PRs and comments to Issues. I'm half expecting another PR to suddenly pop up from you...
If we were to move to the ruff formatter, just noticed that the code style badge at the top of the readme would probably need changing.
Absolutely sterling. Thanks again, and for offering your experience with ruff. I think I've just got an emotional attachment to black and struggle to look past it. I certainly wouldn't...
#211 introduced to the release workflow a 20s wait between uploading and installing package. Made no difference - the subsequent 4.1 [release workflow](https://github.com/gerrymanoim/exchange_calendars/blob/00a4098e5854cd1387445cd105de40c49710a0eb/.github/workflows/release.yml) can be [seen to have](https://github.com/gerrymanoim/exchange_calendars/runs/7088986375?check_suite_focus=true) still tested...
Finally fixed in #216. Using `github.ref_name` to specify the required version [seems to have done the job](https://github.com/gerrymanoim/exchange_calendars/runs/7199351069?check_suite_focus=true#step:7:1).
This issue was not fixed with #216 after all - the log for the 4.2 release shows that pip couldn't install the uploaded package. On https://github.com/rsheftel/pandas_market_calendars/issues/208 @Stryder-Git [points out](https://github.com/rsheftel/pandas_market_calendars/issues/208#issuecomment-1249620294) that...
Tried changing to just look at the test repo with --index-url although failed (release 4.2.1) as pip unable to locate all dependencies at test repo. Could have included --no-deps although...
Thank you for that @Stryder-Git. I was struggling yesterday to appreciate the need in your workflow for `pip install .`. All clear now! I've had another bash at it (#237)...
Hopefully resolved by #237. Close if workflow releases next release (after 4.2.3) without a hitch.