Marcus Read

Results 93 comments of Marcus Read

@gerrymanoim, is it intended that this PR will be merged? Seems that it includes some nice tests that are missing for `calendar_helpers`.

Would it be worthwhile defining a documentation style? I've been writting documentation for new code in accordance with the [numpy style guide](https://numpydoc.readthedocs.io/en/latest/format.html) which I understand can be read by Sphinx...

#106 added tutorials and overhauled README.md.

@limx0, thanks for the info. By coincidence, yesterday I found the same is true of 28 June 2021. **Both 2020-08-19 and 2021-06-28 shoud be declared as late opens.** https://www.hkex.com.hk/News/Market-Communications/2021/2106282news?sc_lang=en https://www.hkex.com.hk/News/Market-Communications/2021/2106283news?sc_lang=en...

There is. You should be able to just define the `special_opens_adhoc` property in [`XHKGExchangeCalendar`](https://github.com/gerrymanoim/exchange_calendars/blob/4e60ce2c4a064ba070774f73d699f4a628b580db/exchange_calendars/exchange_calendar_xhkg.py#L237). The doc for the [property as defined on the base class](https://github.com/gerrymanoim/exchange_calendars/blob/4e60ce2c4a064ba070774f73d699f4a628b580db/exchange_calendars/exchange_calendar.py#L505) explains what's expected. I think...

Hi @j7zAhU. `exchange_calendars` has historically only been concerned with regular trading times. Although, that's not to say that it couldn't incorporate additional timings. I suspect we'd be open to a...

@LaurensBosscher, thank you for this heads up!!

This issue is also mentioned in #128.

👍 That definitely seems like the way to go for performance and flexibility. Rust is still stuck on my todo list ☹️ I'm wondering to what degree it would complicate...

Sounds good. I've certainly noticed Rust pushing it's way into python projects. Learning Rust is on my 2024 todo list. Unfortunately I can't see that I'll be in a position...