Marcus Philip

Results 13 comments of Marcus Philip

OK. It seems adding stdlib as a dependency requires altering the travis build script. BTW, Modulefile is deprecated. One should use have a metadata.json instead. Incidentally I have created one....

Here is the Jenkins XML for the build when it's finished (somewhat shorted): An interesting observation is that the `BuildData` action contains the last commit and the `changeSet` contains the...

I see that `PushHookTriggerHandlerImpl#createRevisionParameter()` creates a `RevisionParameterAction` with `combineCommits = false`, which is used in `shouldSchedule()` and `foldIntoExisting()` in this class. Maybe this is the error?

> I see that `PushHookTriggerHandlerImpl#createRevisionParameter()` creates a `RevisionParameterAction` with `combineCommits = false` ... > > Maybe this is the error? Manual testing in our Jenkins instance with modified plugin suggests...

We have a similar behaviour, although in our case we have two separate pushes happening during a build is running. Our job is configured to disallowed concurrent builds. So a...

I am trying to use `slackUserIdsFromCommitters()` but it seems reasonable to guess that it's very similar to `notifyCommitters`. I can confirm that it seems like switching user id resolver forth...

Ha, it seems this is fixed in latest code, but in latest release 3.0.0, that I have, it is broken: https://github.com/voxpupuli/puppet-mongodb/blob/v3.0.0/lib/puppet/provider/mongodb_replset/mongo.rb#L149 This was the fix: https://github.com/voxpupuli/puppet-mongodb/commit/25d2486217531e526e3009b6c83e0cdb3058e051 **So fix is to...

This code [manifests/server/config.pp#L166](https://github.com/voxpupuli/puppet-mongodb/blob/dbbfb88b59dbd7c0dc592c409b443997fc4537d3/manifests/server/config.pp#L166) actually creates a mongorc.js file if all of handle_creds, auth and store_creds are true. I tested this now and it seems to work. It was a "documentation...

It's these two that I think needs to be tweaked: > store_creds Store admin credentials in mongorc.js file. Uses with create_admin parameter > handle_creds Set this to false to avoid...