Marcus Müller comments

Results 470 comments of


                                            Marcus Müller

Add Bundle Installer for Windows (and Mac)

Hm that SYSCONFDIR forbidding was introduced by the GNUDIRs transition and might be obsoleted by this change. Anyways, `-DGR_IGNORE_SYSCONFDIR_SET=On`

Add runtime-changeable min/max frequency support for DigitalNumberControl

Hi @vaibhavj2006 ! You will need to "sign-off" your commits, see https://github.com/gnuradio/gnuradio/pull/7955/checks?check_run_id=53503193807 for details

Deprecate "QT GUI Push Button" in favor of "QT GUI Msg Push Button"

Dear @SanchitKS12, you don't need to be assigned such a small issue. Just hand in a PR! Thank you!

blocks: peak_detector gets wrong peak or fails to find peak

Thank you for this excellent bug report!

blocks: peak_detector gets wrong peak or fails to find peak

Discussion from chat with bug reporter: Yes. We should **deprecate this block**.

blocks: peak_detector gets wrong peak or fails to find peak

Erroneously closed (depreciaiton is the first step)

blocks: Add fail_if_exists option to file_sink (FileSink should have an option to fail if file already exists #1288)

hi @snk-git-hub ! Welcome here! Looking forward to your contributions! just: These checkboxes up there are not for decoration! You need to actually *do* the things that you tick boxes...

blocks: Add fail_if_exists option to file_sink (FileSink should have an option to fail if file already exists #1288)

So, I did the mechanical things! 1. removed the unused `#include ` 2. remove the unused `d_fail_if_exists` in `file_sink_impl`: you handle this in `file_sink_base`! 3. added the empty line that...

blocks: Add fail_if_exists option to file_sink (FileSink should have an option to fail if file already exists #1288)

Hi, as explained above, you need to sign your commits. Please actually read the output when a CI workflow fails! It links to useful information on how to solve the...

blocks: Add fail_if_exists option to file_sink (FileSink should have an option to fail if file already exists #1288)

You added a folder "Temporary". Remove that. Please do your due diligence! (Adding the `Don't Merge` label, because I've spent now very much time on this PR, and it's not...