Marcus Müller
Marcus Müller
@willcode I would, but I can't in this shape: this PR uses aggregate initialization, and prior to ( #7640 )'s https://github.com/gnuradio/gnuradio/pull/7640/commits/75141abcba9f3ad1d3c4b8ddf64b014cb99c9835 , that's not possible. So, I had to split...
yep, that seems appropriate.
Do you think? Or was this just the buildup for the season's main action? Find out more in the next PR!
needs removal of designated initializers as well
Hey @Harishankar14, any update?
@Harishankar14 great! as said, draft PRs are more than welcome.
open investigative question: why is `gcc` (not `g++`) being invoked with `-stdlib=libc++ -lc++`. - ah it's `add_compile_option Also, Alex says it should default to Ninja, but it doesn't. Possible solution:...
yes, the GRC parameters in the .yml file describing are badly named. @LRJohnson11 would you be able to change them and make a PR? I'd go for the three parameter...
(we should probably go through the other blocks in that family as well)
Reminder, @yarda had a look at this a while ago when we were packaging GNU Radio 3.8: https://github.com/gnuradio/gnuradio/issues/2534#issuecomment-514133746