Marcus Klaas de Vries comments

Results 43 comments of


                                            Marcus Klaas de Vries

Make all bounded channels safe

This is probably extremely naive, but can't we work with 64 bit values regardless of architecture? Or do (some) atomic instructions only work with native word sizes?

Improve unbounded channels

Cool! Maybe you should try to merge with the standard library? There seem to be mostly advantages over the current implementation.

Make API more natural for Rust

This issue isn't that the library should be more abstract, but that the constructs aren't idiomatic for Rust.

Added the getTime method

Lekker bezig Moosje!

Allow increment of hour and minute

Of all the pullrequests attempting to implement this functionality, this is easily the best. Strong accept.

Allow increment of hour and minute

The maintainer hasn't been active on github for quite a while.

Allow increment of hour and minute

Nice. Have the changes also landed in the minified version?

Allow increment of hour and minute

AAAHNOOOOIICCEEE

Assert Usage

Can't some of these issues, like the ones in your example, be fixed by more strict typing? E.g. by changing the signature to ``` pub fn bcrypt(cost: u32, salt: &[u8;...

Add result_str, and possibly input_str to Mac

The maintainer seems to have abandoned it. I guess we're all waiting for a new hero to step forth..