Marcus Herrmann

Results 15 comments of Marcus Herrmann

Great PR! The main search input needs both a (screen reader visible) label and a submit button, in my opinion. Input type="search" doesn't suffice for assistive technology.

Updated #650,… - transported the changes regarding `aria-current` from carousel.js to working-example.md - added a sh*tty first draft regarding the necessary text change - but ⚠️ wasn't able to change...

An example: Your toggle button component is literally a `` with `tabindex="0"`, which is a violation of WCAG 4.1.2 at a minimum. [Heydon Pickering wrote about the proper implementation of...

Thanks for the feedback, will look into it and then reopen

In this context, it would be great if we could add `aria-current`to the active ``. See #2116

Now, after a little bit more than a year (and with some user research, conducted by @marcysutton in a Gatsby/React app), I'd like to modify my initial suggestion: https://marcus.io/blog/improved-accessible-routing-vuejs tldr;...

> Focusing the app wrapper may cause some issues. Marcy reached out to me on twitter, I got that part of my research interpretation wrong. Will update the article, soon-ish...

When your marketing material promises WCAG compliance, but the components do not deliver, I myself see this as a defect and not some "enhancement".

@maranran What was the reasoning behind commenting out https://github.com/maranran/eslint-plugin-vue-a11y/blob/master/lib/rules/click-events-have-key-events.js#L31? Is @matthewdouglas' fork the solution, or has it side effects? Can contributors help in any way regarding this? I'm eager to...

Either way, I forked, removed the comment, and adapted it a little, like this: https://github.com/vue-accessibility/eslint-plugin-vue-a11y/blob/master/lib/rules/click-events-have-key-events.js#L31 In a project using this fork the rule works as intended. Failing at ``, but...