Marc Romeyn
Marc Romeyn
General comment: NeMo uses google-style docstrings so please use that format.
This is already a big PR which in this particular case is OK I feel like since it's a port of functionality that exists in the launcher now. But it...
I feel like we should hold off on this until we merge the new entrypoint-API in NeMo-Run, see [docs](https://github.com/NVIDIA/NeMo-Run/blob/c284dcc7005ac5a2183dac661173eee46e05df87/examples/entrypoint/README.md). This will simplify this example considerably while adding more flexibility.
@ShriyaPalsamudram if the script would only show how to do one thing, so let's say llama3-8b I would agree. But this script offers some form of parameterization using argparse +...
@pablo-garay That would be perfect, thanks!