NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard
verified publisher icon NVIDIA

add auto configurator to NeMo

Open dimapihtar opened this issue 1 year ago • 3 comments

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

dimapihtar avatar Jul 11 '24 11:07 dimapihtar

General comment: NeMo uses google-style docstrings so please use that format.

marcromeyn avatar Aug 20 '24 08:08 marcromeyn

This is already a big PR which in this particular case is OK I feel like since it's a port of functionality that exists in the launcher now. But it seems like it's not rebased correctly and therefore it contains many un-related changes. Can this be fixed @dimapihtar ?

marcromeyn avatar Aug 28 '24 07:08 marcromeyn

This is already a big PR which in this particular case is OK I feel like since it's a port of functionality that exists in the launcher now. But it seems like it's not rebased correctly and therefore it contains many un-related changes. Can this be fixed @dimapihtar ?

@marcromeyn @ko3n1g no worries about that. It was my try to rebase PR to main branch but it still has a lot of conflicts so I've already created new one based on main branch. I keep this PR opened in order to not to miss @marcromeyn comments. I'll close this PR a bit later.

New PR: https://github.com/NVIDIA/NeMo/pull/10270

dimapihtar avatar Aug 28 '24 10:08 dimapihtar