Marc Philipp

mod_mam_sql stores invalid xml

8

> What version of ejabberd are you using? 17.09 > What operating system (version) are you using? CentOS > How did you install ejabberd (source, package, distribution)? source > What...

Spek should be compatible with JUnit Platform suites

1

JUnit 5.8 introduced `@Suite` classes and a new engine to execute them. Spek is currently incompatible with them because it does not use the `UniqueId` passed in to `TestEngine.discover` for...

Configure dependency cache on GitHub Actions

9

In order to speed up builds on GitHub Actions: https://github.com/marketplace/actions/cache ### Jobs - [ ] Linux (uses `container: junitteam/build:latest`) - [ ] Windows - [ ] Mac OS - [...

Decide how to report 'unexpected' and 'actual' values in an exception

5

This is a follow-up on #138 where we used `new AssertionFailedError(message, expected, actual)` to pass `expected` and `actual` for `assertEquals`, `assertSame`, and `assertNull`. However, we should consider passing `unexpected` and...

Resolves #1739.

Replacement API for Hamcrest methods in ExpectedException and ErrorCollector

1

We need to decide if we need replacement APIs for the methods that take Hamcrest matchers as parameters. The discussion has started in #1150.

Decouple JUnit from Hamcrest

4

@npryce has nicely summed up the reasons to do this in his blog: http://www.natpryce.com/articles/000806.html

If we decide to move on to JDK 6 or 7 for JUnit 5.0 we need to update the CSS. Maybe use the one from #887.

Currently, when an assertion fails the exception message only includes the expectation, but not the actual events. For example, the following assertion inspired by the JUnit 5 codebase fails with...

ExpectedEvent.with should support all primitive types

1

In addition to `String` and `Duration`, `ExpectedEvent.with` should support (at least) all primitive value types. Currently, calling `with("name", 1)` yields a `IllegalArgumentException`: https://github.com/gunnarmorling/jfrunit/blob/3848a086f60474733a7b3cc73dd0ecc95a856a55/src/main/java/dev/morling/jfrunit/ExpectedEvent.java#L82