Marco Costa
Marco Costa
@delner, the `payload` hash in question is only used in the local method scope of `#process_action`: https://github.com/DataDog/dd-trace-rb/blob/e391d2eb64d3c6151a4bdd2710c6a8c7c1d57457/lib/ddtrace/contrib/action_pack/action_controller/instrumentation.rb#L106-L140 In this context, `payload` holds state and is passed around to [three](https://github.com/DataDog/dd-trace-rb/blob/e391d2eb64d3c6151a4bdd2710c6a8c7c1d57457/lib/ddtrace/contrib/action_pack/action_controller/instrumentation.rb#L76) [different](https://github.com/DataDog/dd-trace-rb/blob/e391d2eb64d3c6151a4bdd2710c6a8c7c1d57457/lib/ddtrace/contrib/action_pack/action_controller/instrumentation.rb#L17)...
I've spend a some time trying out a few implementations that would work with `ActiveSupport::Cache::Strategy::LocalCache` but, because `LocalCache` is `prepend`ed into other classes, there's no way to affect all Modules/Classes...
Hi @mbarany, thank you for reporting this issue. I tried to reproduce the issue you described, the change in `service` when invoking `Datadog.tracer.active_correlation.to_h`, but I can't quite get the same...
Thank you for the additional data point, @jonfreeland! This is super helpful to the investigation, alongside the info provided by @mbarany.
👋 @mbarany and @jonfreeland, sorry for the super long wait. With the release of `ddtrace` [v1.0.0](https://github.com/DataDog/dd-trace-rb/releases/tag/v1.0.0) we've rewritten most of the logic around how the active correlation works. **If you...
@delner the default options are awesome! I can think of many times in the past where this would have been a great solution to my repetitive configuration struggles. Super excited...
👋 @tak1n, we have a large effort at Datadog around improving tracing for distributed payloads, Kafka being the most popular system representing such payloads today. This effort is being championed...
Thank you for the detailed suggestion, @cabello. We've had requests to improve visibility into GraphQL in the past, and I believe your request makes a lot of sense. When I...
@zachmccormick & @rahul342, I took at this and got a bit of work done to fix it: https://github.com/DataDog/dd-trace-rb/pull/2262 The issue can be solve by simply reporting the correct backend type...
I'm changing the way we tag these external resources to use a new tag `peer.service`, this PR will be updated to use this new approach.