Felipe Guizar Diaz

Results 17 comments of Felipe Guizar Diaz

Yes I want populate the filterable list with that. I forked your library and I'm working in implement it, I'm going to make a pull request when the changes are...

Hi, In my case I used an AutocompleteTextView instead of the default list, therefore you can implement a custom adapter to get the data on-demand. https://github.com/marconi1992/MaterialChipsInput/commit/565a92da916ef29df304a463c2528cff7f344c62 ```java mBusinessTags.setFilterableList(new ArrayList()); //...

@Inkdpixels This is currently supported since the 2.1.1 hypernova version. https://github.com/airbnb/hypernova/commit/ca74d2123708f29ab3bb3cc897874e2d894b8394#diff-19b62c5258de09e32f97ee52dd8e9615 is this still valid?

@tsukhu It's a good idea, It's simple and helpful. Feel free to fix them, I'll really appreciate it.

I think passing a nullish value in `mapDispatchToProps` is not recommended `connect(mapStateToProps, null)` or `connect(mapDispatchToProps, null)` We should only use `mapStateToProps` alone `connect(mapStateToProps)`. However, it's a common pattern I've seen...

> Hmm. Passing a null value for `mapDispatch` is entirely legal :) For example, say you want to pass in either `mergeProps` or `options` and the component doesn't need to...

> Not sure what you mean by "v7 is using the types for v6". Nevermind, I thought we didn't have `v7` types because the folder is missing but the latest...

@markerikson just to confirm. Is the change from my PR suitable for this? or should we proceed differently? I included a custom eslint rule in my codebase to prevent developers...

> Just to be sure: when working with v8, you have _deinstalled_ `@types/react-redux`, right? That package is not required any more and would cause all kinds of conflicts. > >...

@phryneas I updated the type tests in the project to reproduce the issue. https://github.com/reduxjs/react-redux/pull/1929 You will see the errors when running `yarnpkg type-tests`. Feel free to update the test case...