Marco de Jongh

Results 12 comments of Marco de Jongh

Descendants uses [enzyme find](https://github.com/airbnb/enzyme/blob/master/docs/api/ReactWrapper/find.md) internally which always starts at the top of the render, NOT the descendants of the first element of the render. I'm pretty sure this is intended...

Not sure if ```found``` communicates it clearly enough. Maybe the descendants behaviour can be merged into ```contains```?

You could write a assertion with `descendants` because it accepts a [enzyme selector](https://github.com/airbnb/enzyme/blob/master/docs/api/selector.md). I think the following would work: ``` const actual = expect(

@robwise I think something along the lines of @ljharb's proposal would work. But it's only delaying the inevitable, unless you're absolutely sure you never want to UI test.

@bassettsj What exactly are you trying to achieve by using chai-jquery? Is it because you want to be able to do jQuery style selectors when testing shallow render results? In...

Could you make sure that you assign issues that you're picking up? I have 20% time tomorrow so I intend to fix all issues raised by me. I went ahead...

Someone described how to mark as failed using the rest API here: https://www.reddit.com/r/sonarr/comments/nm36np/comment/gzq65do/?utm_source=reddit&utm_medium=web2x&context=3 can be helpful to whoever decides to implement this issue. I found it a bit hard to...

> External mismatches can allow you to upgrade across a system incrementally. We would like this feature! And wouldn't mind building it. But it would also need to include the...

Yeah happy to hand this over to anyone 👍

I've disabled greenkeeper because it was too spammy, from now on I'll try to pay more attention to this repo