Marc Khouzam comments

Results 311 comments of


                                            Marc Khouzam

Add default completion command even if there are no other sub-commands

I've let this rot for too long. Let's plan it for the next release. Come August iI will run some tests on it and make sure it is good.

Allow user to add completion for powershell alias

This whole idea came out of a comment from the PR that added Powershell completion to kubectl: https://github.com/kubernetes/kubernetes/pull/103758#issuecomment-1007586166 There was a project that implemented a hard-coded script for powershell completion...

Allow user to add completion for powershell alias

Still valid

Review inconsistent `go` file license headers

Steve's approach sounds right to me. I found the CNCF's copyright notice policy: https://github.com/cncf/foundation/blob/main/copyright-notices.md which confirms the "Cobra authors" approach. This is what the Helm project does for example. By...

Add similar whitespace escape logic to bash v2 completions than in other completions

Thanks @kangasta for the contribution 🎉 I will need to take the time to give this proper attention but I will not have time for the next couple of weeks....

Add similar whitespace escape logic to bash v2 completions than in other completions

Ok, I've started looking into this and I started by running some tests and the PR seems to work as expected. Next step was to add a test to the...

feat(completion): support no-space completions for short flags

Thanks for the contribution @mazitovt ! > Duplicate of #1727? As @Luap99 noticed we just got a similar contribution in #1727. I've started reviewing that one and we should be...

feat(completion): support no-space completions for short flags

@mazitovt I've had a look at this PR and it is a step in the right direction. It is very similar to #1727 which came in first, so I'll focus...

Rename `SuggestionsMinimumDistance` to `SuggestionsMaximumDistance`

Thanks @mrpinsky. I believe your argument makes sense, "maximum" makes more sense. However, as you point out, this is a public API so we are not allowed to change it....

Use FlagErrorFunc for validateRequiredFlags and validateFlagGroups

Thanks @SVilgelm ! On first look this does makes sense. However I am concerned about backward-compatibility where an existing program would unexpectedly see it's `FlagErrorFunc()` being called for a new...