cobra
cobra copied to clipboard
spf13
feat(completion): support no-space completions for short flags
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thanks for the contribution @mazitovt !
Duplicate of #1727?
As @Luap99 noticed we just got a similar contribution in #1727. I've started reviewing that one and we should be getting it merged soon. I'll still have a look at yours as it may give a different perspective.
@mazitovt I've had a look at this PR and it is a step in the right direction. It is very similar to #1727 which came in first, so I'll focus on #1727 for now.
One note for your info is that although the Go logic works with your PR, the actual shell completion does not work as expected because the different shell script need to be updated to support this usecase. Note that #1727 has the same problem, but we'll work at getting it resolved.
The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:
- After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the PR is closed. You can:
- Make a comment to remove the stale label and show your support. The 60 days reset. - If a PR has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interseted in reopening.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Reopening. I plan on reviewing this. The other PR was closed by the author.
The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:
- After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the PR is closed. You can:
- Make a comment to remove the stale label and show your support. The 60 days reset. - If a PR has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interested in reopening.