Marc J. Schmidt comments

Results 444 comments of


                                            Marc J. Schmidt

Nested joins on backreferences are not deserialized properly

This should be fixed with the latest join fixes/improvements

[Bug] Self-Reference Fields Serialized into Nested Objects without Joinning

Thanks @TheNightmareX, this should be fixed in master. Please check it out and let me know. (tests added in https://github.com/deepkit/deepkit-framework/commit/aa90b17a28cdf0b081736579c7463920eb97412a)

[Feature] Serialization Consistency for Optional Properties

I think the behaviour here is changed because when you do `new MyEntity` with the constructor property, it will actually set the property to the prototype, not matter if undefined...

fix(orm): fix useJoin JoinDatabaseQuery generic for optional properties

Fixed in a different way via https://github.com/deepkit/deepkit-framework/commit/e229380fd8fc14b4f4e38a25294a79a124534522

SQL BatchUpdate does not work when different class properties are edited

Fixed in https://github.com/deepkit/deepkit-framework/commit/513a8180a51bb7611d5fae805084c9f85ef06c02

`type-compiler` installation does not account for multiple Typescript versions when using `pnpm`

Isn't this solved by using Node's --preserve-symlinks? Then `@deepkit/type-compiler` should be resolved correctly (I haven't tested it though) > Simply flipping these statements resolves the issue, and I can't think...

`type-compiler` injection cannot be updated or patched

Good idea! Would you be interested in providing a PR?

fix(sql): dates should be nullable without casting as JSON

thanks @fergusean! I also adjusted sqlite/postgres to use the new date type resolver https://github.com/deepkit/deepkit-framework/commit/ab12802c307d9dcf17925526dd5dcf87c87e8899

Support for CUID and NanoId

I think string would be enough, no? ```typescript class User { cuid: string & PrimaryKey = cuid(); } ```

Support for CUID and NanoId

True, no validation happens. When we add a new type like `CUID` we can add validation logic like so https://github.com/deepkit/deepkit-framework/blob/master/packages/type/src/serializer.ts#L1865-L1871 and https://github.com/deepkit/deepkit-framework/blob/master/packages/type/src/serializer.ts#L2050-L2054