deepkit-framework icon indicating copy to clipboard operation
deepkit-framework copied to clipboard

fix(sql): dates should be nullable without casting as JSON

Open fergusean opened this issue 1 year ago • 1 comments

Summary of changes

Same as #552, but for dates. Can't use Date | null on SQL entities right now without Deepkit trying to cast them as JSON into the database.

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • [X] I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

fergusean avatar Feb 11 '24 01:02 fergusean

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.58%. Comparing base (51b9b36) to head (d146d79).

:exclamation: Current head d146d79 differs from pull request most recent head c5760c1. Consider uploading reports for the commit c5760c1 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files         193      193           
  Lines       20448    20448           
  Branches     5311     5311           
=======================================
  Hits        16070    16070           
  Misses       4378     4378           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 11 '24 01:02 codecov-commenter

thanks @fergusean! I also adjusted sqlite/postgres to use the new date type resolver https://github.com/deepkit/deepkit-framework/commit/ab12802c307d9dcf17925526dd5dcf87c87e8899

marcj avatar Mar 24 '24 12:03 marcj