react-skylight

react-skylight copied to clipboard

Replace deprecated componentWillMount with componenDidMount

1

`componentWillMount` is deprecated in react 16.3 and some linters and frameworks (like Gatsby) fail to build due to the use of the deprecated method `componentWillMount`. The method is only used...

rlamana

I have a dropdown box in the page. This dropdown is still active and showing on top even when popup is active.

shameerahamed

Dialog contents focusable when dialog is hidden

7

Hi everyone. With the dialog visible or hidden, it's possible to press the Tab key until the dialog contents have focus, enabling them to be interacted with. I believe this...

GuiRitter

Ability to show/hide close button

1

I have added this additional prop to show/hide close button. As there is already a method exposed to trigger close sometimes we need to have custom close button in the...

sahil290791

Can I open another popop in a opening popop? I have modal one and modal two, I click the button to open the modal two, and I can the 'Open...

dcuti8

Hi everyone. I'm talking about the `beforeOpen`, `afterOpen`, `beforeClose` and `afterClose` callbacks. If they also exist for `SkylightStateless`, they are not working, so they need to be fixed. If they...

GuiRitter

Styles should preferably be controlled with CSS and not JS

5

By relying on JS to set inline styles, I am now finding it very troublesome to implement mobile friendliness. If the styles were controlled with CSS, I could have easily...

ericluwj