react-skylight icon indicating copy to clipboard operation
react-skylight copied to clipboard

Styles should preferably be controlled with CSS and not JS

Open ericluwj opened this issue 8 years ago • 5 comments

By relying on JS to set inline styles, I am now finding it very troublesome to implement mobile friendliness. If the styles were controlled with CSS, I could have easily used media queries.

ericluwj avatar Mar 21 '16 03:03 ericluwj

@ericluwj thanks for your feedback. I'm thinking an elegant way to use a separated CSS file, instead inline JS styles, maybe an option to escape in line JS styles.

marcio avatar Mar 21 '16 14:03 marcio

👍 would very much like this over having it in the JS and inline. :)

AdamSkaidon avatar May 04 '16 21:05 AdamSkaidon

I'd like a way to add an CSS class name to the main dialog element.

viridia avatar May 20 '16 22:05 viridia

:+1: any updates?

matt16749-zz avatar Jul 12 '16 22:07 matt16749-zz

@viridia : yes being able to pass class names to the components would help a lot.

jakefavour avatar Sep 11 '16 18:09 jakefavour