Marcin Grzejszczak
Marcin Grzejszczak
Yeah - that's what we were assuming (that it might be hard) and what we were planning to eventually do (generate it ourselves)
Yeah, I'm back. So the only "global" thing you can set on the `ObservationConfig` currently is `Observation.GlobalObservationConvention`. We've removed the `KeyValuesProvider` - it got merged into `ObservationConvention`.
Of course I would. Micrometer 2.0.0 is a breaking release. What should be the branch / module strategy in Resilience4j ?
Great, so Micrometer 2.0 is currently in snapshots really. Are you willing to take in 2.0 snapshots of micrometer or do you prefer to hook on milestones? When are you...
OK so once I have some spare cycles I'll create a PR against 2.0 snapshots of Micrometer and we'll continue from there!
Just a small update. We have decided not to release micrometer 2.0.0. The whole observation feature will be available in micrometer 1.10.0.
So @RobWin with this actually not being a breaking change - which branch should I target?
I've finally started to look into this! Sorry for the delay. I would like to hook in somewhere around here https://github.com/resilience4j/resilience4j/blob/master/resilience4j-micrometer/src/main/java/io/github/resilience4j/micrometer/tagged/AbstractCircuitBreakerMetrics.java#L139-L143 . What I would like to achieve is that...
> Or do you plan to combine Observation with a CircuitBreaker? I wanted to combine the two. In Spring Cloud Sleuth with Spring Cloud CircuitBreaker the way we do it...