Marcel Thole

Results 18 comments of Marcel Thole

not exactly. If i look into the [diff](https://github.com/cebe/php-openapi/compare/1.4.2...1.5.0#diff-1fdd7a9a3b147bb4ecab41f346c8cea969f57052ae0b5ef20bd9ad11b9d65335) one part is the huge amount of `ReferenceContext::reduceDots` calls in the current version. Here the difference of the xdebug trace ![grafik](https://user-images.githubusercontent.com/850125/159745185-3632e208-d20e-42d5-b883-677df7333ef1.png)

I tried to look around in the Codebase and read about the AST from the PHP Parser. To solve this problem, i think a new analyser layer should be used?...

Awesome. Thanks a lot for the PoC. I will look into it and add roave better reflection and test it against some projects. I will try to create a Merge...

> I will try to create a Merge Request against your MR in the beginning of the next week :) maybe, the next week is a little bit longer than...

hey, sorry for the late response. What did you mean with the same input path name? Could you add an example? Do you want to add the same file twice?

I would like to see PHP 8.3+ support and native typehints. And i guess that it could be easier for further development steps if the Routes would be immutable. But...

Ah didn't know that version schema. Than i could update this to Version 6.x?

To the phpbench topic: In this case i created the bench Testfile and stored the result and compared it later with this patch. https://phpbench.readthedocs.io/en/latest/guides/regression-testing.html#comparison For later steps it could be...

#207 will only help in the case where i would generate a route if i saw it correctly. That has no impact on the bootstrapping time to match a route....

ah i guess i also found a bug here. I need to add a test for routings like `/api/export/country{/countryId}.csv` that this will match `/api/export/country.csv` and `/api/export/country/1.csv` (same behavior for `/api/export.{format}`...