Marcello DeSales
Marcello DeSales
hey @mmenbawy, I can't verify this MR... The build in your project is failing and I can't run the examples... * I re-wrote the `Dockerfile` to correctly use python3.8 *...
# Running Docker-compose Build And Original Image * Same error while running in a regular machine using your image at `mostafaelmenbawy/gfpgan:latest` ```console $ docker run -ti -v $PWD/inputs:/app/inputs -v $PWD/results:/app/results...
# No Dockerfile * I don't see anything in this PR :) * To me, Docker environment is when I can do `docker-compose up --build` As an Engineer who depends...
@CJWBW I'm inspecting the contents of your image at `r8.im/xinntao/gfpgan@sha256:fec8c51c3017f1afbf8b0eed7f4ba51158e49b527b92aea91833aed32559e2ef`, and here's so far what I've gathered... * I couldn't find the original `Dockerfile` for the image at the URL...
@gitgrimbo No problem... I have used the latest/greatest Docker build capabilities to separate the Build Image and the Runtime image... We can still decrease the size of the final image,...
@gitgrimbo Yeah we can change it as needed... Let me verify...
@gitgrimbo I just updated the image and verified it is all good!
@gitgrimbo let me know the direction... Once you merge `x-remove-php` I can create another PR and rebuild the Dockerfile
???? @checketts Where's the PR?
# NOTE * This is if you use sh to start your script