Marc Bachmann

Results 125 comments of Marc Bachmann

> the Alt key together with the arrow up/down key at the top/bottom of the element, thus indicating that the element should be moved up or down. Actually, vscode is...

I guess we can close this for now

Oh, we could implement if you really want to. But at the moment it's also conflicting with jumping to the end of a block. I'm not really a fan to...

I'd rather bind `CMD + ALT + ⬆️ `

> And on Windows that’d be CTRL + ALT + ⬆️? yes

I think it would make sense to completely migrate this module to the opentelemetry ecosystem. Most metrics in this module would need to be re-implemented using the [`meter.createValueObserver`](https://github.com/open-telemetry/opentelemetry-js/blob/48b60c980c904e45aea556f0a3177e64d46134a7/examples/metrics/metrics/observer.js#L23-L31) gauge. Just...

And here's a first working POC: https://github.com/marcbachmann/opentelemetry-node-metrics I have 3 TODO's in the code that might need some fixes.

While reading more source code, I found out that the `.update` only works when calling `.bind` first. Unlike as other metrics. ```js const meter = meter.createValueObserver(name, {description}) const instrument =...

Awesome, thanks for the update. 👏 I already found one small issue which either could use a fix or just some additional documentation. The configuration `DOMAIN=*.subdomain.example.com,*.example.com` fails with the following...

I've fixed the compatibility with opentelemetry 0.27 in https://github.com/marcbachmann/opentelemetry-node-metrics/pull/3 For the metrics, it should be straight forward to migrate and even keep the compatibility: https://github.com/marcbachmann/opentelemetry-node-metrics/blob/master/index.js#L9-L16