Marc Bachmann

This issue is still present. Is there any reason not to merge this?

Just a note. Currently I'm extracting the traceId in the `pino-http` `customProps` function: https://github.com/pinojs/pino-http/blob/0c778530cecac64ca80ae4e88624c55c942413b9/logger.js#L122 Having the traceId is enough in most cases, as that's the entrypoint of retrieving a trace...

lol. I initially used this module because I wasn't able to get wkhtmltopdf to work at all. this module should work with custom fonts though. Regarding the `page-break-inside` issue, you...

I didn't have a look at your html yet, but there are some errors that don't get catched in your code. You're always using next like this. ``` js function(err,...

I assume this was a syntax error. So I'm closing this for now.

are you pushing your `node_modules` to git? Don't do that. All the platform specific modules won't work unless you run `npm rebuild`.

@Lichtjaeger thanks for the hint. I'll integrate phantomjs 2 in this module as soon as it's stable on all platforms. That's also the case for the phantomjs module on npm....

@ripper2hl you have to install the binary yourself. You can use `apt-get install`, `brew` or a docker container.

[email protected] now uses phantomjs v2. Have fun

Oh, that just reminded me that this is probably caused by a default margin on the body of the header & footer elements. I'm not 100% sure whether this is...